Skip to content

[fix] : add context timeout when making listNodes k8s call #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Mar 26, 2025

This fix adds a timeout for listNodes k8s call so that if apiserver is not responding, the call should timeout after some time and not hang indefinitely somehow.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the bugfix for any bug fixes in the changelog. label Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.98%. Comparing base (6d72edb) to head (cac06b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   72.95%   72.98%   +0.03%     
==========================================
  Files          14       14              
  Lines        2596     2599       +3     
==========================================
+ Hits         1894     1897       +3     
  Misses        537      537              
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulait rahulait merged commit 62815d7 into main Mar 26, 2025
9 checks passed
@rahulait rahulait changed the title [fix] : add context timeout to prevent node_controller for hanging [fix] : add context timeout when making listNodes k8s call Mar 27, 2025
@rahulait rahulait deleted the use-timed-context branch March 27, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants