Skip to content

[feat] Add IPv6 ingress address support for NodeBalancer services #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 4, 2025

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Mar 3, 2025

Implement a new flag --enable-ipv6-for-loadbalancers to allow adding IPv6 addresses for LoadBalancer services. Also, added support to enable it per service using an annotation (service.beta.kubernetes.io/linode-loadbalancer-enable-ipv6-ingress). This feature provides flexibility for users who prefer IPv6 networking, with the following changes:

  • Add UseIPv6ForLoadBalancers option to Linode cloud provider options
  • Modify makeLoadBalancerStatus to add IPv6 address when the flag is set
  • Add a new test case to verify IPv6 address selection
  • Update documentation to explain the new IPv6 configuration option

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Implement a new flag `--use-ipv6-for-loadbalancers` to allow using IPv6 addresses for LoadBalancer services. This feature provides flexibility for users who prefer IPv6 networking, with the following changes:

- Add `UseIPv6ForLoadBalancers` option to Linode cloud provider options
- Modify `makeLoadBalancerStatus` to use IPv6 address when the flag is set
- Add a new test case to verify IPv6 address selection
- Update documentation to explain the new IPv6 configuration option
@komer3 komer3 added the new-feature for new features in the changelog. label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.13%. Comparing base (dcaae71) to head (7098890).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   71.82%   72.13%   +0.30%     
==========================================
  Files          14       14              
  Lines        2435     2462      +27     
==========================================
+ Hits         1749     1776      +27     
  Misses        525      525              
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM

@komer3 komer3 merged commit 07ba90a into main Mar 4, 2025
11 checks passed
@komer3 komer3 deleted the ipv6-address-lb-svc branch March 4, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants