Skip to content

fix: always deploy ingress for team core apps #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

j-zimnowoda
Copy link
Contributor

📌 Summary

This change ensures that ingress for team apps is always created regardless of app being enabled or not.

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@j-zimnowoda j-zimnowoda changed the title Fix ingress for team alertmanager fix: always deploy ingress for team core apps Apr 30, 2025
Copy link

github-actions bot commented Apr 30, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
48.98% (+0.09% 🔼)
1061/2166
🔴 Branches
33.07% (+0.47% 🔼)
212/641
🔴 Functions
40.67% (+0.33% 🔼)
122/300
🔴 Lines
48.3% (+0.1% 🔼)
938/1942

Test suite run success

92 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from dd15637

@j-zimnowoda j-zimnowoda merged commit 5121cad into main Apr 30, 2025
7 of 8 checks passed
@j-zimnowoda j-zimnowoda deleted the fix-ingress-for-team-alertmanager branch April 30, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants