-
Notifications
You must be signed in to change notification settings - Fork 170
feat: rely solely on metadata name #2040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success89 tests passing in 9 suites. Report generated by 🧪jest coverage report action from fbb81cd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my small comment above, I would say LGTM. I made some similar adjustments to repo.ts in the APL-706 PR for improving the error handling. Also we might want to adopt the sanity checks for kind, name and team id in regard to the file paths. However, this can be done when we move these things to a library.
APL-612