Skip to content

feat: rely solely on metadata name #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 11, 2025
Merged

feat: rely solely on metadata name #2040

merged 34 commits into from
Apr 11, 2025

Conversation

j-zimnowoda
Copy link
Contributor

@j-zimnowoda j-zimnowoda commented Apr 4, 2025

APL-612

Copy link

github-actions bot commented Apr 4, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
47.96% (-0.22% 🔻)
1000/2085
🔴 Branches
31.48% (+0.18% 🔼)
193/613
🔴 Functions
38.49% (+0.56% 🔼)
112/291
🔴 Lines
47.19% (-0.24% 🔻)
881/1867
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 common/crypt.ts
20.16% (-0.16% 🔻)
12.5% (-0.4% 🔻)
14.29%
19.35% (-0.16% 🔻)
🔴 common/repo.ts
46.29% (-4.03% 🔻)
40% (-4.44% 🔻)
35.48% (+2.15% 🔼)
46.75% (-4.25% 🔻)

Test suite run success

89 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from fbb81cd

@merll merll changed the title Apl 612 feat: consolidate name and id where identical Apr 8, 2025
@j-zimnowoda j-zimnowoda marked this pull request as ready for review April 9, 2025 09:00
@j-zimnowoda j-zimnowoda requested review from CasLubbers and merll April 9, 2025 09:00
@j-zimnowoda j-zimnowoda changed the title feat: consolidate name and id where identical feat: rely solely on metadata name Apr 9, 2025
@CasLubbers CasLubbers self-assigned this Apr 10, 2025
@merll merll self-requested a review April 10, 2025 11:56
Copy link
Contributor

@merll merll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my small comment above, I would say LGTM. I made some similar adjustments to repo.ts in the APL-706 PR for improving the error handling. Also we might want to adopt the sanity checks for kind, name and team id in regard to the file paths. However, this can be done when we move these things to a library.

@j-zimnowoda j-zimnowoda requested review from CasLubbers and merll April 11, 2025 08:09
@j-zimnowoda j-zimnowoda enabled auto-merge (squash) April 11, 2025 12:34
@j-zimnowoda j-zimnowoda merged commit 0f89b2b into main Apr 11, 2025
5 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-612 branch April 11, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants