Skip to content

feat: render only relevant values for team-ns helm chart #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Dec 23, 2024
Merged

feat: render only relevant values for team-ns helm chart #1872

merged 31 commits into from
Dec 23, 2024

Conversation

j-zimnowoda
Copy link
Contributor

No description provided.

@j-zimnowoda
feat: limit values that are send to team-ns chart
ebf705a
@j-zimnowoda
feat: limit values that are send to team-ns chart
2307296
@j-zimnowoda
feat: limit values that are send to team-ns chart
dcdd14a
@j-zimnowoda
feat: limit values that are send to team-ns chart
6725158
@j-zimnowoda
feat: limit values that are send to team-ns chart
2763e08
@j-zimnowoda
feat: limit values that are send to team-ns chart
84f2937
@j-zimnowoda
feat: limit values that are send to team-ns chart
4f6c1ee
@j-zimnowoda
feat: limit values that are send to team-ns chart
8577244
@j-zimnowoda
feat: limit values that are send to team-ns chart
9d6ef28
@j-zimnowoda
feat: limit values that are send to team-ns chart
8ab43ad
@j-zimnowoda
feat: limit values that are send to team-ns chart
2573cbc
@j-zimnowoda
feat: limit values that are send to team-ns chart
4f77456
@j-zimnowoda
fix: core team services
83213af
@j-zimnowoda
fix: core team services
94d4d1f
@j-zimnowoda
fix: rm unused blackbox exporter svc
5d8ff27
@j-zimnowoda
fix: explicit properties
4d78f3e
@j-zimnowoda
feat: limit values that are send to team-ns chart
db0f672
@j-zimnowoda
feat: limit values that are send to team-ns chart
085f485
@j-zimnowoda
feat: limit values that are send to team-ns chart
f98bd00
@j-zimnowoda
fix: explicit properties
103ca67
@j-zimnowoda
fix: explicit properties
2c52541
@j-zimnowoda
fix: explicit properties
4d93d4d
@j-zimnowoda
fix: explicit properties
8153897
@j-zimnowoda
fix: explicit properties
4c9e2e3
@j-zimnowoda
fix: explicit apps
80c3415
@j-zimnowoda
fix: remove unused symlink
a94086b
@j-zimnowoda
fix: add resource quota
7249ea9
@j-zimnowoda
fix: add isMultitenant
27e89a3
@j-zimnowoda
fix: gloablPullSecret
e9b6349
@j-zimnowoda j-zimnowoda requested a review from merll December 18, 2024 14:06
CasLubbers
CasLubbers requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks going through the PR. Still need to test fresh install. Upgrade scenario works for me.

merll
merll approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@merll merll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for functionality. Optimizations as Cas suggested may still apply, have not verified that.

@Ani1357 Ani1357 self-requested a review December 23, 2024 13:16
Ani1357
Ani1357 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested upgrade scenario and also local compare using the bin/compare.sh -l name=team-ns-demo.

CasLubbers
CasLubbers approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh install works.

@CasLubbers CasLubbers merged commit 37bdd3c into main Dec 23, 2024
5 checks passed
@CasLubbers CasLubbers deleted the APL-451 branch December 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merll merll merll approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

@srodenhuis srodenhuis Awaiting requested review from srodenhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-zimnowoda @merll @CasLubbers @Ani1357