Skip to content

fix(apl-146): validate-templates #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2024
Merged

fix(apl-146): validate-templates #1672

merged 3 commits into from
Aug 14, 2024

Conversation

CasLubbers
Copy link
Contributor

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

j-zimnowoda
j-zimnowoda approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the verbose flag and removed not relevant skipKinds

Ani1357
Ani1357 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and results are back. LGTM

@CasLubbers CasLubbers merged commit df5d907 into main Aug 14, 2024
7 checks passed
@CasLubbers CasLubbers deleted the apl-146 branch August 14, 2024 07:47
Ani1357 pushed a commit that referenced this pull request Sep 17, 2024
@CasLubbers @j-zimnowoda @Ani1357
fix(apl-146): validate-templates (#1672)
168c185 
Co-authored-by: Jehoszafat Zimnowoda <[email protected]>
(cherry picked from commit df5d907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CasLubbers @j-zimnowoda @Ani1357