Fix github build failure #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiang95-dev
changed the title
abhisheknath2011
approved these changes
Jul 17, 2024
kmcclenn
pushed a commit
to kmcclenn/openhouse
that referenced
this pull request
Jul 17, 2024
## Summary The build failed because of missing `khttp` library that is required by `springdoc-openapi` plugin. This library has been removed from maven2 repo from 2022, so not sure why the previous build succeeded (maybe github caches some gradle libraries). The `springdoc-openapi` plugin has removed the usage of `khttp` too since `1.5.0`. I'm upgrading the version to `1.6.0` which is the latest that gradle 6 supports. More details in this issue: springdoc/springdoc-openapi-gradle-plugin#92. ## Changes - [ ] Client-facing API Changes - [ ] Internal API Changes - [x] Bug Fixes - [ ] New Features - [ ] Performance Improvements - [ ] Code Style - [ ] Refactoring - [ ] Documentation - [ ] Tests For all the boxes checked, please include additional details of the changes made in this pull request. ## Testing Done <!--- Check any relevant boxes with "x" --> - [ ] Manually Tested on local docker setup. Please include commands ran, and their output. - [ ] Added new tests for the changes made. - [ ] Updated existing tests to reflect the changes made. - [x] No tests added or updated. Please explain why. If unsure, please feel free to ask for help. - [ ] Some other form of testing like staging or soak time in production. Please explain. For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request. # Additional Information - [ ] Breaking Changes - [ ] Deprecations - [ ] Large PR broken into smaller PRs, and PR plan linked in the description. For all the boxes checked, include additional details of the changes made in this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The build failed because of missing
khttplibrary that is required byspringdoc-openapiplugin. This library has been removed from maven2 repo from 2022, so not sure why the previous build succeeded (maybe github caches some gradle libraries). Thespringdoc-openapiplugin has removed the usage ofkhttptoo since1.5.0. I'm upgrading the version to1.6.0which is the latest that gradle 6 supports.More details in this issue: springdoc/springdoc-openapi-gradle-plugin#92.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.