This repository was archived by the owner on Feb 17, 2021. It is now read-only.
Tour ID as part of classes #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // loadTour if we are calling startTour directly. (When we call startTour | ||
| // from window onLoad handler, we'll use currTour) | ||
| if (!currTour) { | ||
|
|
||
| // Check validity of tour ID. If invalid, throw an error. | ||
| if(!tour.id || !validIdRegEx.test(tour.id)) { |
There was a problem hiding this comment.
Let's add a sanity check for tour.
|
This looks good to me. I'll wait for the Travis build to complete and pull this in. |
|
Looks like Travis build failed because code coverage dropped below 80%. Could you add a unit test to cover new functionality? |
added 3 commits
April 22, 2015 14:16
…for tour id in startTour().
…e when a tour ends (we should create a new one for each tour).
|
Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append tour class to HopscotchBubble, if tour. Also move RegEx check for tour id in startTour().
Resolves issue #123.