Add unit test to cover new functionality. Also destroy HopscotchBubble when a tour ends (we should create a new one for each tour).

Author: Timothy Lindvall

src/js/hopscotch.js

@@ -1089,7 +1089,9 @@
         utils.addClass(el, 'hopscotch-callout no-number');
       } else {
         currTour = winHopscotch.getCurrTour();
-        utils.addClass(el, 'tour-' + currTour.id);
+        if(currTour){
+          utils.addClass(el, 'tour-' + currTour.id);
+        }
       }
 
       /**
@@ -1323,6 +1325,19 @@
       return bubble;
     },
 
+    /**
+     * Destroy the bubble currently associated with Hopscotch.
+     * This is done when we end the current tour.
+     *
+     * @private
+     */
+    destroyBubble = function() {
+      if(bubble){
+        bubble.destroy();
+        bubble = null;
+      }
+    },
+
     /**
      * Convenience method for getting an option. Returns custom config option
      * or the default config option if no custom value exists.
@@ -1996,6 +2011,7 @@
 
       this.removeCallbacks(null, true);
       this.resetDefaultOptions();
+      destroyBubble();
 
       currTour = null;
 

test/js/test.hopscotch.js

@@ -156,6 +156,12 @@ describe('Hopscotch', function() {
       hopscotch.endTour();
     });
 
+    it('should complain if no tour data is passed in', function(){
+      expect(function(){
+        hopscotch.startTour();
+      }).toThrow(new Error('Tour data is required for startTour.'));
+    });
+
     it('should reject tour IDs that include invalid characters', function(){
       expect(function(){
         hopscotch.startTour({
@@ -1285,6 +1291,22 @@ describe('HopscotchBubble', function() {
       expect(content).toBe('It\'s a shopping list');
       hopscotch.endTour();
     });
+
+    it('Should include tour ID as part of bubble classes', function(){
+      hopscotch.startTour({
+        id: 'hs-test-tour-class',
+        steps: [ {
+          target: 'shopping-list',
+          placement: 'left',
+          title: 'Shopping List',
+          content: 'It\'s a shopping list'
+        } ]
+      });
+      bubble = document.querySelector('.hopscotch-bubble.tour-hs-test-tour-class');
+      console.log(document.querySelector('.hopscotch-bubble').classList);
+      expect(bubble).not.toBe(null);
+      hopscotch.endTour();
+    });
   });
 
   describe('Step Number', function() {