Skip to content

Fix remaining spotbugs and checkstyle complaints and enable PR blocking #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

jogrogan
Copy link
Collaborator

@jogrogan jogrogan commented May 12, 2025

  • Fix remaining spotbugs and checkstyle complaints and enable PR blocking when either is broken.
  • Enable Java 11

A lot of this was auto generated.
Verified existing tests work and cli functions normally

The standards and exclusions added are consistent with linkedin repositories.

Copy link
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Funny to see the same mistakes made over and over.

@jogrogan jogrogan merged commit b26900f into main May 14, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/spotbugs branch May 14, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants