Fix ScriptImplementor projection when using filters and add many tests #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are split into different commits:
Copying comment added to code:
// We need to run the plan without field trimming enabled. The intention of field trimming is to optimize
// away unused fields. Calcite is able to make micro optimizations to the plan but at the cost of making
// no guarantees about what that fields will be named in the resulting RelNode. For the ScriptImplementor,
// field names are important because they are used to generate the final SQL against the sink table. This will
// almost always require some top-level Project in the plan, but with trimming enabled, identity projects
// (just field renames) are optimized out of the plan.
// See discussion in https://issues.apache.org/jira/browse/CALCITE-1297
I was able to get something similar working by adding a top-level project right before the ScriptImplementor call but this felt more hacky and caused the where clauses to be generated as something strange:
Copying that solution for visibility: