Skip to content

Make lots of checkstyle changes - plan to enable blocking PRs soon, still some more involved issues #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

jogrogan
Copy link
Collaborator

@jogrogan jogrogan commented May 5, 2025

  • Make lots of checkstyle changes - plan to enable checkstyle/spotbugs to block PRs soon, still some more involved issues that will be handled in subsequent PRs
  • Fixed Makefile inconsistencies
  • Support latest strimzi version causing build failures [See 2nd commit] - Changes in strimzi can be found at https://strimzi.io/docs/operators/latest/deploying

@jogrogan jogrogan force-pushed the jogrogan/checkstyle branch from 7afeed0 to d790e8b Compare May 5, 2025 19:49
Copy link
Collaborator

@nguyent8 nguyent8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fixing the strimzi issue

@jogrogan jogrogan merged commit 0dcd5ed into main May 6, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/checkstyle branch May 6, 2025 00:27
ryannedolan pushed a commit that referenced this pull request May 13, 2025
…till some more involved issues (#133)

* Make lots of checkstyle changes - plan to enable blocking PRs soon, still some more involved issues

* Support changes in latest strimzi version

* Fix kafka order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants