Skip to content

Fix PipelineReconciler namespace #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Conversation

jogrogan
Copy link
Collaborator

An incorrect assumption was made that the yaml of each sub-resource inside the pipeline object will contain its own namespace information. While this can be true if the corresponding table/job template explicitly set their own namespace, in most cases the namespace is set automatically at resource creation time to be the same as the pipeline object.

  • The explicit setting of namespaces will only ever be needed if deploying resources across namespaces, which isn't supported today anyway as this breaks the Kubernetes ownership model.

Also fix various checkstyle issues

@jogrogan jogrogan merged commit c2829e0 into main Apr 25, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/pipelineReconciler branch April 25, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants