Default to ANSI dialect #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryannedolan
reviewed
Mar 24, 2025
hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sJobDeployer.java
Outdated
Show resolved
Hide resolved
ryannedolan
reviewed
Mar 24, 2025
hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sEngineTable.java
Show resolved
Hide resolved
ryannedolan
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not convinced MysqlSqlDialect is correct to use over AnsiSqlDialect.
Both seem to have the same quoting mechanisms set up, MySQL seems to have slight differences to types & casting (which is confirmed won't work in Flink), null handling (which shouldn't matter to us), and contains some additional functions (which are also unconfirmed will work in Flink).