Skip to content

Fix pipeline ownership on update #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Conversation

jogrogan
Copy link
Collaborator

There was a bug if you recreate the same materialized view, the pipeline ownership to the view was getting thrown out.

0: Hoptimator> create or replace materialized view venice."test-store$my-view4" as select "KEY" as "KEY_id", "VALUE" as "stringField" from kafka."existing-topic-1";
No rows affected (1.9 seconds)

kind: Pipeline
metadata:
  creationTimestamp: "2025-03-17T21:34:56Z"
  generation: 1
  name: venice-test-store-my-view4
  namespace: default
  ownerReferences:
  - apiVersion: hoptimator.linkedin.com/v1alpha1
    kind: View
    name: venice-test-store-my-view4
    uid: 80db4704-02a8-4a5f-af63-8167ea2b213a

Copy link
Collaborator

@ehoner ehoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jogrogan jogrogan enabled auto-merge (squash) March 17, 2025 21:53
@jogrogan jogrogan merged commit 9455bc3 into main Mar 17, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/fixOwnershipUpdate branch March 17, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants