Z-order painting #466
Closed
Z-order painting #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, let's get that piet stuff merged and then this should be straightforward. Thanks for taking this on! |
|
okay #472 brings your piet changes into druid, so this should be unblocked shortly. 👌 |
|
I created a new PR #504 since it was easier to just copy all the changes rather than fixing all merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #430
This requires linebender/piet#117 to have access to
current_transform()which is necessary to keep track of applied transformations.One thing that is missing here (also because I'm not 100% sure) is keeping track of clipping. Right now previous clipping is not applied to z-order painting. It would be a bit trickier since
PaintCtxwould need to keep track of clipping.One other thing that I was thinking about was thinking about is whether it would make sense to allow negative
z_indexes to allow painting below content?