Deref, Index, and InArc lenses #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
index
branch
3 times, most recently
from
edbc31b to
6bb1c41
Compare
Ralith
commented
Dec 1, 2019
Ralith
force-pushed
the
index
branch
4 times, most recently
from
945ecb2 to
df63e6f
Compare
Ralith
force-pushed
the
index
branch
2 times, most recently
from
a811626 to
70e0f84
Compare
Ralith
commented
Dec 2, 2019
druid/src/lens.rs
Outdated
| /// ``` | ||
| fn make_mut<L, C, D>(self, lens: L) -> MakeMut<Self, L, C> | ||
| where | ||
| Self: Sized + Lens<A, Arc<C>>, |
There was a problem hiding this comment.
This feels like a hack, but it works.
Ralith
force-pushed
the
index
branch
4 times, most recently
from
13df44f to
affb5be
Compare
Ralith
changed the title
Ralith
commented
Dec 3, 2019
| /// lens.put(&mut x, 42); | ||
| /// assert_eq!(&*x, &[0, 1, 42, 3]); | ||
| /// ``` | ||
| fn in_arc(self) -> InArc<Self> |
There was a problem hiding this comment.
Bikeshedding still welcome, though I think this is probably adequate.
There was a problem hiding this comment.
I can't think of anything better? maybe just arc, but either or.
Ralith
force-pushed
the
index
branch
3 times, most recently
from
4ed9487 to
6712b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #344.
Note that this does not provide a way to index into an
Arc<Vec<T>>. That's intentional, as any such operation would cause a deep copy in everyWidget::event.