Multi-format copy and paste #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a slog, and there are problems, but it will get runebender moving forward. [mac] First cut of custom clipboard paste types This checkpoint attempts to generalize the idea of pasting custom types on macOS in a way that I *hope* is fairly flexible. I don't expect this to last, because I would like to have a common mechanism for reading and writing of custom types to the clipboard, but I'd like to check this in before I make too much of a mess. Impl most of a new clipboard API This is the bones of a more flexible system for copy/paste. The most basic idea is that when the user wants to copy or paste custom types, they define some marker struct and implement the `ClipboardRead` and or `ClipboardWrite` traits. Methods on these traits can be implemented per-platform, to return platform specific information about how to serialize and deserialize a given type. If impls are omitted for a platform, the type is ignored on that platform. The intent with this API is to be maxmimally accomodating to the fact that copy/paste APIs are very different on different platforms; instead of trying to come up with a lowest common feature set, we instead try to be as general as possible, without sacrificing ergonomics. TODOs: - I would like to prove this out on at least one additional platform - I would like to make copy/cut easier to use with this API; in particular I would like to support copying multiple data-types. [mac] Support multiple format cut/copy [win] Get basic cut/copy working with new API [win] Preliminary copy/paste of custom formats and multi-format [shell] Redo clipboard code Ultimately I'm not entirely happy with this API, but eventually you have to move on and live your life.
raphlinus
approved these changes
Nov 22, 2019
druid-shell/src/clipboard.rs
Outdated
| } | ||
|
|
||
| impl ClipboardFormat { | ||
| /// Create a new `ClipboardFormat` with the given `FormatId` and byes. |
|
/bloat |
🗜 Bloat check ⚖️Comparing 17dfe68 against 35d0052
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was very frustrating! I spent a lot of time trying to come up with a more "just works" API, but it ended up getting hairy and ultimately I ripped it out and tried to just do the simplest API I could.
In any case, this is working on mac, windows and gtk. The only bug I'm aware of is on GTK; if you put multiple formats on the clipboard, and one of them is text, the clipboard doesn't seem able to retrieve the text. I'm not totally sure what's going on there, but I'm not going to fight it right now, it's a pretty marginal case all in all.
Anyway: this covers the common case (text) and the special case required by runebender (multi-format vector data) comfortably. There may be future limitations; in particular I think doing copy/paste for images is going to be a headache and a half, but we can worry about that at some future date.