Skip to content

Track window creation and deletion: Take 2 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

LiHRaM
Copy link
Collaborator

@LiHRaM LiHRaM commented Nov 9, 2019

closes #242

This is the second attempt at adding event handlers for tracking window creation and deletion, this time using the trait implemented in #283.

@LiHRaM LiHRaM force-pushed the track-window-creation-and-deletion-2 branch from a392f32 to 9e5264c Compare November 9, 2019 22:52
AppDelegate now has two new handlers: window_removed and window_added
@LiHRaM LiHRaM force-pushed the track-window-creation-and-deletion-2 branch from 9e5264c to 9063738 Compare November 9, 2019 22:54
@LiHRaM LiHRaM requested a review from cmyr November 9, 2019 23:01
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -308,16 +308,44 @@ impl<T: Data + 'static> AppState<T> {
.and_then(|w| w.get_menu_cmd(cmd_id))
}

fn with_delegate(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, glad this worked 👍

@LiHRaM LiHRaM merged commit 552e9a5 into master Nov 10, 2019
@LiHRaM LiHRaM deleted the track-window-creation-and-deletion-2 branch November 10, 2019 17:17
@LiHRaM LiHRaM mentioned this pull request Nov 10, 2019
@cmyr cmyr mentioned this pull request Dec 31, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track window creation & deletion in AppDelegate
2 participants