chore: bump cairo to v2.11.4 #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto bump/cairo_v2.10
…nto bump/cairo_v2.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the Cairo version to
v2.11.4.outdated contracts and scripts have been removed for ease of maintainability. To facilitate tracing, versioning has been added to the README for both the core contracts and the scripts directory.
Additional points
scarb linte.g. usingforloops when iterating over spans andwhileloops for conditional loops. While making this change, I observed that thetest_partial_absorb_with_redistribution_entire_trove_debttest did not iterate fully over each nested loop. This required some assertions in the tests to be relaxed because the edge cases were not actually executed previously.generate_argto generate price feed for yangs. This introduces some randomness to the tests, and may require some tests that previously passed to be relaxed e.g. a wider error margin.