feat: receptor #600
Merged
feat: receptor #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milancermak
suggested changes
Oct 1, 2024
A few other (already filtered) suggestions from Claude:
|
milancermak
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Heh, I also used Claude to suggest names. I was going for some terminology to steer or guide stuff (boats, trains), trying to convey the fact that the module "just moves stuff around" - it came up with things like Helmsman, Raftsman, Hoghead, Hauler, Conductor, Signalman 😆
Suddenly, Receptor sounds pretty good 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Receptor (open to suggestions for names) module that submits yin's price to Shrine for the Controller to actuate on.
The yin price is taken as the median of CASH-{DAI, USDC, USDT} pairs from Ekubo's oracle extension, based on a TWAP duration that can be adjusted by admin. The quote tokens can also be adjusted if desired in the future e.g. swapping one of them out for LUSD. I considered taking the median of an arbitrary number of quotes, but that would make the contract unnecessary complex e.g. implementing a heap to sort any number of quotes.
Additionally, the Receptor module also implements the ITask interface to streamline its interaction by keepers. Therefore, the primary method of updating yin's price is via
ITask.execute_task(). Nevertheless, there is also aupdate_yin_pricethat is restricted by access control that allows the update frequency of the task to be bypassed, similar toseer.update_prices()andseer.execute_task(). At the moment, this is not necessary, but it gives some flexibility for the future in case the yin's price needs to be updated in some user flow.Initially, I wanted to include the Sepolia and mainnet scripts in this PR, but I think they can be taken up separately while UX design is ongoing.