Skip to content

feat: add artifacts #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2024
Merged

feat: add artifacts #598

merged 3 commits into from
Sep 13, 2024

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Sep 12, 2024

This PR adds the artifacts for core contracts deployed on mainnet.

@tserg tserg requested a review from milancermak September 12, 2024 09:57
Copy link
Contributor

@milancermak milancermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milancermak
Copy link
Contributor

I'm wondering if we should also offer ABI files (just the "abi" section) since those would be the most interesting for integrators I think. Not sure what's the best practice here.

@kseikyo any thoughts?

@kseikyo
Copy link

kseikyo commented Sep 12, 2024

I'm wondering if we should also offer ABI files (just the "abi" section) since those would be the most interesting for integrators I think. Not sure what's the best practice here.

It's a nice addition. I think just a folder called abis with the files would work well, as it keeps things consistent and makes it easy to see when an ABI has changed.

The standard is to have a local copy in the project, but some projects have a repo dedicated to ABIs. I'm not sure we need that. If we reach a point where we have different versions, we can discuss how to handle them then.

@milancermak
Copy link
Contributor

Cool, thanks for the input.

I ran jq .abi on all the artifact JSONs and stored the results in separate JSON files under abis/.

@tserg
Copy link
Collaborator Author

tserg commented Sep 13, 2024

Should we move the full artifact files into a contract_classes folder? I think it looks better that way 😄

@milancermak
Copy link
Contributor

Yeah, good idea

@tserg tserg merged commit b905a56 into main Sep 13, 2024
1 check passed
@tserg tserg deleted the feat/artifacts branch September 13, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants