-
Notifications
You must be signed in to change notification settings - Fork 1
feat[script]: mainnet deployment #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nto script/mainnet
We should also remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, when reviewing, I realized we'll than have to call accept_admin manually on all modules from the multisig 😬 At least I don't know if there's a way how to do a mutlicall on a multisig.
Does sncast do the fee estimation correctly? Didn't we have a problem with that? FWIW, I think using the MAX_FEE
constant is ok.
I wanted to mention this too but forgot 😄 I did a cursory search earlier in the week and did not see anything related to constructing a multicall for an Argent multisig.
Oh right, we can leave it as it is since it is easy to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds the deployment script for mainnet.
The differences from devnet and Sepolia are:
I have manually tested (2) and having the pending admin accept the admin transfer on devnet locally.
A checklist before running the deployment script:
scripts/deployment/snfoundry.toml
.scripts/src/constants.cairo
.