feat[periphery]: improve trove helper #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseikyo
approved these changes
Jun 13, 2024
|
I have added the following members to
Ready for another round of review. |
kseikyo
approved these changes
Jun 13, 2024
milancermak
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @kseikyo 's request for the return data of
frontend_data_provider.get_trove_assets_info()to include the trove ID and trove owner address, I have added a newTroveInfotype with this information.I have updated the devnet deployment addresses and devnet dump file as well (I had to redeploy devnet as I did not have the original state file). Once approved, I will redeploy the frontend data provider on Sepolia (upgrade would not work since we now need to pass the abbot address into the constructor).