Huggingface Multimodal Universe dataset #274
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds an example CIFAR iterable dataset - Changes to pytorch_ignite.py to work around an ignite bug in iterable datasets pytorch/ignite#3372 - New is_iterable() and is_map() interface on dataset base class to unify discernment logic - Support for abstract base classes that derive from HyraxDataset not being themselves checked for required methods.
mtauraso
force-pushed
the
iterable_dataset
branch
2 times, most recently
from
8fc5c7f to
fea8cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype that allows the use of Huggingface data sets including multimodal universe within hyrax.
Essentially you just have to config it like
The iterative implementation is very slow and heavily instrumented, and may need to be removed. See comments in the code for the state of the perf investigation. Streaming is not supported, but could be added easily
I'm not sure if we should merge this, but putting it out for consideration.
I think there's a case for creating this sort of support after we set up dataset <-> model communication to be more flexible than just a tensor.