Skip to content

Tests: not all supported FreeBSD release versions are listed #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0mp opened this issue Jul 4, 2021 · 2 comments · Fixed by #85
Closed

Tests: not all supported FreeBSD release versions are listed #78

0mp opened this issue Jul 4, 2021 · 2 comments · Fixed by #85

Comments

@0mp
Copy link

0mp commented Jul 4, 2021

Currently, some tests are skipped on FreeBSD. Unfortunately, the only FreeBSD version listed there is freebsd12. As a result tests fail on FreeBSD 13.0 for example.

A solution to this could be using sys.platform.startswith(...) to check if we are running on FreeBSD without having to list all the supported versions explicitly.
@ligurio
Copy link
Owner

ligurio commented Jul 5, 2021

Sure, it should be fixed.

@ligurio ligurio closed this as completed in 9ec7226 Jul 8, 2021
@ligurio
Copy link
Owner

ligurio commented Jul 8, 2021 •
edited
Loading

closed accidentally

@ligurio ligurio reopened this Jul 8, 2021
@ligurio ligurio mentioned this issue Jul 8, 2021
Merged
ligurio added a commit that referenced this issue Jul 8, 2021
@ligurio
Use generic os name in tests
1518a84 
Closes #78
ligurio added a commit that referenced this issue Jul 8, 2021
@ligurio
Use generic os name in tests
1f70f87 
Closes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use generic os name in tests ligurio/unreliablefs
2 participants
@ligurio @0mp