closechannel: add functional options #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested changes
May 23, 2025
lightning_client.go
Outdated
| @@ -2873,7 +2873,7 @@ type PaymentRequest struct { | |||
| // Value is the value of the payment request in millisatoshis. | |||
| Value lnwire.MilliSatoshi | |||
|
|
|||
| /// Timestamp of the payment request. | |||
| // / Timestamp of the payment request. | |||
There was a problem hiding this comment.
nit: just remove the third character instead?
hieblmi
force-pushed
the
no-wait
branch
3 times, most recently
from
0ebc477 to
c92c985
Compare
hieblmi
changed the title
guggero
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
the NoWait flagfunctional options toCloseChannel.