Skip to content

Expose PaymentHash and PaymentPreimage in Balance #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alecchendev
Copy link
Contributor

Closes #2202.

@alecchendev alecchendev force-pushed the 2023-04-expose-hash-in-balance branch from a59ae37 to 797491c Compare April 23, 2023 06:58
@alecchendev alecchendev force-pushed the 2023-04-expose-hash-in-balance branch from 797491c to 29b9eb3 Compare April 23, 2023 07:05
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.64 🎉

Comparison is base (9d5adfc) 91.50% compared to head (29b9eb3) 92.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
+ Coverage   91.50%   92.15%   +0.64%     
==========================================
  Files         104      104              
  Lines       51176    55965    +4789     
  Branches    51176    55965    +4789     
==========================================
+ Hits        46829    51574    +4745     
- Misses       4347     4391      +44     
Impacted Files Coverage Δ
lightning/src/ln/mod.rs 86.36% <0.00%> (-8.64%) ⬇️
lightning/src/chain/channelmonitor.rs 95.95% <100.00%> (+1.45%) ⬆️
lightning/src/ln/monitor_tests.rs 98.14% <100.00%> (-0.13%) ⬇️

... and 23 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wpaulino wpaulino self-requested a review April 27, 2023 22:28
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@wpaulino wpaulino merged commit 3a643df into lightningdevkit:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose PaymentHash in Balance
4 participants