Skip to content

keysend: correct TLV extension field table #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

keysend: correct TLV extension field table #15

merged 1 commit into from
Feb 4, 2022

Conversation

valentinewallace
Copy link
Contributor

Keysend's TLV extension type was documented the wrong (and indeed bogus) table, as pointed out by @joostjager here

@valentinewallace
keysend: correct TLV extension field table
daf1707 
Keysend's TLV extension type was in a bogus table
@valentinewallace valentinewallace mentioned this pull request Feb 4, 2022
Merged
t-bast
t-bast approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@t-bast t-bast merged commit b00212b into lightning:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinewallace @t-bast