Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversations addon's pill for DKIM verfier is missing #395

Closed
sha-265 opened this issue Oct 5, 2023 · 2 comments
Closed

Conversations addon's pill for DKIM verfier is missing #395

sha-265 opened this issue Oct 5, 2023 · 2 comments
Assignees
Labels
bug Something isn't working compatibility Related to a specific Thunderbird version or another add-on
Milestone

Comments

@sha-265
Copy link

sha-265 commented Oct 5, 2023

If I'm not a complete dumbass who unable to find this "pill", there is a bug on TB (115.3.1) with Conversion addon (v5.3.1) and DKIM verifier (v4.1.3), that cause this pill to disappear.

Help me find this pill (if it exists):
image

And here is the same email opened in the default viewer:
image

The only thing that could be relevant that I found in TB's error log:

Uncaught TypeError: MutationObserver.observe: Argument 1 is not an object.
    <anonymous> chrome://conversations/content/stubWrapper.js:21
6 stubWrapper.js:21:13
    <anonymous> chrome://conversations/content/stubWrapper.js:21

Thanks.

@lieser lieser added bug Something isn't working compatibility Related to a specific Thunderbird version or another add-on labels Oct 5, 2023
@Standard8
Copy link

The problem appears to be this bit of the code: https://github.com/search?q=repo%3Alieser%2Fdkim_verifier+tab.url%3F.startsWith%28%22chrome%3A%2F%2Fconversations%2F%22%29&type=code

I suspect this due to how the Thunderbird rework has changed all the tab processing - the tab no longer has a url field option, and so chrome://conversations can't be matched.

I'm not sure of an easy option of what to do there, except for maybe detecting if Conversations is installed/active and running it regardless.

@sha-265 sha-265 changed the title Conversations addon's DKIM verfier pill is missing Conversations addon's pill for DKIM verfier is missing Oct 6, 2023
@lieser
Copy link
Owner

lieser commented Oct 22, 2023

Thanks for reporting the issue, this should be fixed now. If you want to try it out already you can use the following version:
[email protected]

@Standard8 You there correct about the problematic code.
I extended your proposed check a little to work with the case that a message is viewed in a tab or windows (in the classic view).

I noticed that if Conversations is installed browser.messageDisplay.onMessageDisplayed is not triggered even then viewing single messages in Thunderbird's 3pane tab. I guess this is something Conversations prevents?
This is nothing that interferes with my add-on, it actually means the check I do fo conversation there is not needed currently. I still decided to leave it in in case it changes in the future.

@lieser lieser closed this as completed Oct 22, 2023
@lieser lieser added this to the 5.4.0 milestone Oct 22, 2023
@lieser lieser self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Related to a specific Thunderbird version or another add-on
Projects
None yet
Development

No branches or pull requests

3 participants