Feat: LIP-32 - GateSeal v2.0 #85
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDZhon
requested changes
Jun 5, 2025
| ### Overview | ||
|
|
||
| GateSeal V2 will retain the one-time activation logic but allow: | ||
| - An initial expiry up to 3 years (set at deployment), |
There was a problem hiding this comment.
Suggested change
| - An initial expiry up to 3 years (set at deployment), | |
| - An initial expiry up to 1 year (set at deployment), | |
| - An overall expiry up to 5 years (set at deployment), |
There was a problem hiding this comment.
We have N prolongations, so why do we need a cap in the contract? It seems like an extra precaution.
There was a problem hiding this comment.
want to limit the overall duration of the same instance still to avoid some possibly forgotten stuff
| - Public method `prolong()` will be gated by internal checks: | ||
| - `not activated` | ||
| - `not expired` | ||
| - `prolongations_remaining > 0` |
There was a problem hiding this comment.
Suggested change
| - `prolongations_remaining > 0` | |
| - `prolongations_remaining > 0` | |
| - can't be called more than once for the current period | |
| - can't be called earlier than 1 mo before the currently assigned expiration |
Co-authored-by: Eugene Mamin <[email protected]>
Co-authored-by: Eugene Mamin <[email protected]>
tamtamchik
reviewed
Jun 6, 2025
|
|
||
| GateSeal V2 will retain the one-time activation logic but allow: | ||
| - An initial expiry up to 3 years (set at deployment), | ||
| - Up to N prolongations (e.g., 5), each increasing validity by up to 6 months, |
There was a problem hiding this comment.
Suggested change
| - Up to N prolongations (e.g., 5), each increasing validity by up to 6 months, | |
| - Up to N prolongations (e.g., 5), each increasing validity by up to 6 months (set at deployment), |
| ### Overview | ||
|
|
||
| GateSeal V2 will retain the one-time activation logic but allow: | ||
| - An initial expiry up to 3 years (set at deployment), |
There was a problem hiding this comment.
We have N prolongations, so why do we need a cap in the contract? It seems like an extra precaution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not use LIP-32. It's booked for GateSeal v2.0