-
Notifications
You must be signed in to change notification settings - Fork 8
Add functionality for the fpsemi-examples
presentations
#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CI will fail until we release a version of |
The author value bug Where author values are given as the sole argument to these functions, things sometimes break (as in, Python freezes for a while, and then gets killed). This is not the case for every function. Playing with it now, it appears to be the as @james-d-mitchell suspected, with author values being interpreted as integers. The following is evidence for this:
(The segfault with being since in |
The best |
efcd019
to
a518184
Compare
@MTWhyte should be possible to take this to completion now! |
a518184
to
72d5b5a
Compare
02d12f7
to
e6daba3
Compare
e6daba3
to
77becbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes, then I'm happy to merge, thanks @MTWhyte
Note: This PR is on top of #84
This PR adds functionality for the
fpsemi-examples
presentations, addressing issue #83. It is not entirely finished, but in a state where @james-d-mitchell and I might discuss finishing touches. This might include:symmetric_group
, but not set this up for other functions yet. I'll do this after we've figured out what's going on.