Updated to GameInput v1.1 #12806
Merged
Updated to GameInput v1.1 #12806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
force-pushed
the
update
branch
4 times, most recently
from
0388f60 to
66200b0
Compare
|
@madebr, can you look at the Windows clang build? |
slouken
force-pushed
the
update
branch
2 times, most recently
from
754bbd3 to
9957fa8
Compare
The biggest change is that the C API is no longer available. Here are more details: https://www.nuget.org/packages/Microsoft.GameInput Fixes libsdl-org#12802
|
@madebr, thank you for the fixes. I accidentally force pushed on top of them, so I recreated them in my commit. |
Don't worry about it :) |
sezero
reviewed
Apr 12, 2025
| #define GAMEINPUT_API_VERSION 0 | ||
| #endif | ||
|
|
||
| #if GAMEINPUT_API_VERSION == 1 |
There was a problem hiding this comment.
should this be == 1 or >= 1 like elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is that the C API is no longer available.
Here are more details:
https://www.nuget.org/packages/Microsoft.GameInput
Fixes #12802