Skip to content

Added SDL_SetRenderTextureAddressMode() and SDL_GetRenderTextureAddressMode() #10328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

slouken
Copy link
Collaborator

@slouken slouken commented Jul 20, 2024

It's not clear we need this yet, and if we do, whether people need control over U and V separately and additional addressing modes, so I'm going to go ahead and leave this as draft for now.

Fixes #4820

@slouken slouken added this to the 3.x milestone Jul 20, 2024
@slouken slouken marked this pull request as draft July 20, 2024 16:56
@jayschwa
Copy link
Contributor

An example where U and V need different wrap modes is a Wolfenstein-style renderer. Wall textures repeat horizontally, but not vertically. In my experience with OpenGL, it is important to clamp the V axis, even if the V coordinate is in the range [0, 1].

@slouken
Copy link
Collaborator Author

slouken commented Aug 6, 2024

I'm going to go ahead and close this PR. We can reopen it later if we want to use it as a base for a future API.

@slouken slouken closed this Aug 6, 2024
@slouken slouken deleted the texture-address-mode-api branch August 6, 2024 17:13
@slouken slouken restored the texture-address-mode-api branch March 28, 2025 03:21
@slouken slouken reopened this Mar 28, 2025
@slouken slouken modified the milestones: 3.x, 3.4.0 Mar 28, 2025
@slouken slouken force-pushed the texture-address-mode-api branch 4 times, most recently from 1f7294d to a89bb73 Compare March 28, 2025 18:35
@slouken slouken force-pushed the texture-address-mode-api branch from a89bb73 to d894666 Compare March 28, 2025 19:33
@slouken slouken marked this pull request as ready for review March 28, 2025 19:34
@slouken slouken force-pushed the texture-address-mode-api branch 2 times, most recently from 3d91658 to b452323 Compare March 28, 2025 20:09
@slouken slouken force-pushed the texture-address-mode-api branch from b452323 to 007b7a6 Compare March 28, 2025 20:21
@slouken slouken merged commit 633b9f6 into libsdl-org:main Mar 28, 2025
39 checks passed
@slouken slouken deleted the texture-address-mode-api branch March 28, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiling (repeating) texture
3 participants