check for resolv.h and arpa/nameser.h #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Looks good to me. I'll merge once the CI is green. |
botovq
approved these changes
Aug 1, 2025
|
grepping the include/compat directory for "HAVE_*_H" shows there is also a HAVE_READPASSPHRASE_H, but that macro isn't even defined by the autoconf build. It doesn't cause me any build issues so I'm not gonna touch it. Every other HAVE_*_H macro is properly defined in the CMake build. |
|
Thanks for pointing it out. That's something that looks pretty harmless but should be fixed. I opened #1191 for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake build does not define these macros, autoconf build does. This fixes the CMake build and brings it on par with autoconf.
Fixes #1189