-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Draft: WebRTC Implementation for Browser to Browser #5978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Draft: WebRTC Implementation for Browser to Browser #5978
Conversation
…sport to work with a relay server. Implements a protobuf stream wrapper to write Signaling messages over the relay. Exposes the rtc peer connection on a Connection.
This pull request has merge conflicts. Could you please resolve them @elijahhampton? 🙏 |
…unctions to libp2p_webrtc_utils. Adds tracking for connection states through callbacks for SignalingProtocol. Creates directory for circuit-relay-v2 implementation.
transports/circuit-relay-v2/build.rs
Outdated
fn main() { | ||
prost_build::compile_protos(&["src/proto/message.proto"], &["src/proto"]) | ||
.unwrap(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick FYI, we should not use prost but instead use quick-protobuf
:). See #3024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks for catching that.
…y with browser transport, not feature gated. Addition of circuit relay v2 package to libp2p exports. Addition of circuit relay v2 protobuf structures.
Hello, I have pushed my updates for the progress I've made on this PR. I am stuck with the dialing process to the relay server. Do you mind reviewing the PR and potentially providing some guidance on what I might be doing wrong? I am using my example in examples/webrtc-browser and I get stuck when attempting to reserve the relay upon calling I realize I've exposed a number of functions and structs that are crate specific as I am attempting to get this working and then potentially merge everything back into the webrtc-websys crate. Thanks. |
Description
Closes #4389. WebRTC implementation for browser to browser. This PR is currently in draft. More functionality will be added in the coming days. The PR is open for feedback and suggestions as the implementation is completed.
Notes & open questions
Change checklist