Add tests for discovery methods in circuit_relay_v2 #750
+200
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sukhman-sukh! It looks like you also implemented the Once that's done, good to merge! Awesome! |
Jineshbansal
pushed a commit
to Jineshbansal/py-libp2p
that referenced
this pull request
Jul 13, 2025
* Add test for direct_connection_relay_discovery * Add test for mux_method_relay_discovery * Fix newsfragments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Added complete set of tests for all the 3 methods provided for relay discovery
Also, the clear_peerdata function was not implemented.
Issue # #749
Closes #749
How was it fixed?
_check_via_peerstoremethod is tested as default_check_via_direct_connectionmethod is tested by manually removing the peer from peerstore after connection to fail peerstore check._check_via_muxmethod is tested by manually removing the peer from peerstore and then mimicing _check_via_direct_connection to return None always as POC.clear_peerdatain the peerstoreCute Animal Picture