Skip to content

fix: allow empty error events #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix: allow empty error events #3082

merged 1 commit into from
Apr 16, 2025
+1 −1

Conversation

achingbrain
Copy link
Member

Some ErrorEvent implementations don't have a .detail field so null-guard on it before accessing properties.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: allow empty error events
31a517b 
Some `ErrorEvent` implementations don't have a `.detail` field
so null-guard on it before accessing properties.
@achingbrain achingbrain requested a review from a team as a code owner April 15, 2025 18:58
@achingbrain achingbrain merged commit ae7d867 into main Apr 16, 2025
45 of 47 checks passed
@achingbrain achingbrain deleted the fix/allow-empty-error-events branch April 16, 2025 07:53
@achingbrain achingbrain mentioned this pull request Apr 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain