This repository was archived by the owner on Apr 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Replace Travis with Github Actions #150
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ef4be87
add test-and-release github action
vogdb 89704e6
delete travis.yml
vogdb 67b0eeb
add installation of 'node-pre-gyp'
vogdb afdb2eb
add automerge github action
vogdb fc30f40
update test-and-release github action with 'test-browser'
vogdb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# Automatically merge pull requests opened by web3-bot, as soon as (and only if) all tests pass. | ||
# This reduces the friction associated with updating with our workflows. | ||
|
||
on: [ pull_request ] | ||
name: Automerge | ||
|
||
jobs: | ||
automerge-check: | ||
if: github.event.pull_request.user.login == 'web3-bot' | ||
runs-on: ubuntu-latest | ||
outputs: | ||
status: ${{ steps.should-automerge.outputs.status }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- name: Check if we should automerge | ||
id: should-automerge | ||
run: | | ||
for commit in $(git rev-list --first-parent origin/${{ github.event.pull_request.base.ref }}..${{ github.event.pull_request.head.sha }}); do | ||
committer=$(git show --format=$'%ce' -s $commit) | ||
echo "Committer: $committer" | ||
if [[ "$committer" != "[email protected]" ]]; then | ||
echo "Commit $commit wasn't committed by web3-bot, but by $committer." | ||
echo "::set-output name=status::false" | ||
exit | ||
fi | ||
done | ||
echo "::set-output name=status::true" | ||
automerge: | ||
needs: automerge-check | ||
runs-on: ubuntu-latest | ||
# The check for the user is redundant here, as this job depends on the automerge-check job, | ||
# but it prevents this job from spinning up, just to be skipped shortly after. | ||
if: github.event.pull_request.user.login == 'web3-bot' && needs.automerge-check.outputs.status == 'true' | ||
steps: | ||
- name: Wait on tests | ||
uses: lewagon/wait-on-check-action@bafe56a6863672c681c3cf671f5e10b20abf2eaa # v0.2 | ||
with: | ||
ref: ${{ github.event.pull_request.head.sha }} | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
wait-interval: 10 | ||
running-workflow-name: 'automerge' # the name of this job | ||
- name: Merge PR | ||
uses: pascalgn/automerge-action@741c311a47881be9625932b0a0de1b0937aab1ae # v0.13.1 | ||
env: | ||
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" | ||
MERGE_LABELS: "" | ||
MERGE_METHOD: "squash" | ||
MERGE_DELETE_BRANCH: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,168 @@ | ||
name: test & maybe release | ||
on: | ||
push: | ||
branches: | ||
- master # with #262 - ${{{ github.default_branch }}} | ||
pull_request: | ||
branches: | ||
- master # with #262 - ${{{ github.default_branch }}} | ||
|
||
jobs: | ||
|
||
check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npm run --if-present lint | ||
- run: npm run --if-present dep-check | ||
|
||
test-node: | ||
needs: check | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [windows-latest, ubuntu-latest, macos-latest] | ||
node: [16] | ||
fail-fast: true | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: ${{ matrix.node }} | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npm install -g node-pre-gyp | ||
- run: npm run --if-present test:node | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: node | ||
|
||
test-browser: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npm run --if-present test:browser | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: browser | ||
|
||
test-chrome: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npm run --if-present test:chrome | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: chrome | ||
|
||
test-chrome-webworker: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npm run --if-present test:chrome-webworker | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: chrome-webworker | ||
|
||
test-firefox: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npm run --if-present test:firefox | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: firefox | ||
|
||
test-firefox-webworker: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npm run --if-present test:firefox-webworker | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: firefox-webworker | ||
|
||
test-electron-main: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npx xvfb-maybe npm run --if-present test:electron-main | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: electron-main | ||
|
||
test-electron-renderer: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- run: npx xvfb-maybe npm run --if-present test:electron-renderer | ||
- uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # v2.1.0 | ||
with: | ||
directory: ./.nyc_output | ||
flags: electron-renderer | ||
|
||
release: | ||
needs: [test-node, test-browser, test-chrome, test-chrome-webworker, test-firefox, test-firefox-webworker, test-electron-main, test-electron-renderer] | ||
runs-on: ubuntu-latest | ||
if: github.event_name == 'push' && github.ref == 'refs/heads/master' # with #262 - 'refs/heads/${{{ github.default_branch }}}' | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- uses: actions/setup-node@v2 | ||
with: | ||
node-version: lts/* | ||
- uses: ipfs/aegir/actions/cache-node-modules@master | ||
- uses: ipfs/aegir/actions/docker-login@master | ||
with: | ||
docker-token: ${{ secrets.DOCKER_TOKEN }} | ||
docker-username: ${{ secrets.DOCKER_USERNAME }} | ||
- run: npm run --if-present release | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we would want the release process to be updated as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you mean integrating the semantic-release then I wanted to do it in a separate PR to keep things separate and clean. Currently working on migrating to Typescript. If you can, please answer my questions above. |
||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added installation of
node-pre-gyp
here. Let me know if I should move it elsewhere.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vogdb It looks like this needs to run after
actions/setup-node@v2
See https://github.com/libp2p/js-libp2p-webrtc-direct/runs/5537246479?check_suite_focus=true
Don't now why PR CI did not fail though
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at #152. Did I understand you correctly?
Btw should be Github Actions enabled somehow to start working on PRs?