This repository was archived by the owner on Sep 10, 2022. It is now read-only.
reset the temporary error catcher delay after successful accept #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
approved these changes
Dec 20, 2021
Stebalien
approved these changes
Dec 21, 2021
|
IIRC, we needed it for some transient errors in TCP (e.g., "no more file descriptors"). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure we need the temporary error catcher in the first place (why would
Acceptreturn a temporary error? At least for QUIC, it never does), but if we're using it, we should reset it after successfully accepting a connection (see documentation ofcatcher.IsTemporary).