Skip to content

fix: error on no valid provs #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
+7 −2
Merged

fix: error on no valid provs #1065

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29a2195
fix: error on no valid provs
guillaumemichel Mar 18, 2025
2a9715e
addressing review
guillaumemichel Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ func (dht *IpfsDHT) handleAddProvider(ctx context.Context, p peer.ID, pmes *pb.M

// add provider should use the address given in the message
pinfos := pb.PBPeersToPeerInfos(pmes.GetProviderPeers())
success := false
for _, pi := range pinfos {
if pi.ID != p {
// we should ignore this provider record! not from originator.
Expand All @@ -368,6 +369,10 @@ func (dht *IpfsDHT) handleAddProvider(ctx context.Context, p peer.ID, pmes *pb.M
// announcement go through.
addrs := dht.filterAddrs(pi.Addrs)
dht.providerStore.AddProvider(ctx, key, peer.AddrInfo{ID: pi.ID, Addrs: addrs})
success = true
}
if !success {
return nil, fmt.Errorf("handleAddProvider no valid provider")
}

return nil, nil
Expand Down