Skip to content

fix: flaky TestFindProviderAsync (dual) #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: flaky TestFindProviderAsync (dual) #1040

merged 1 commit into from
Feb 20, 2025

Conversation

guillaumemichel
Copy link
Contributor

@guillaumemichel guillaumemichel commented Feb 20, 2025 •
edited
Loading

Fixes #1039

  • unable to reproduce failure locally
  • added verbose

@guillaumemichel guillaumemichel marked this pull request as ready for review February 20, 2025 12:38
@guillaumemichel guillaumemichel requested a review from a team as a code owner February 20, 2025 12:38
@guillaumemichel
Copy link
Contributor Author

guillaumemichel commented Feb 20, 2025 •
edited
Loading

Wasn't able to reproduce in the CI. PR will be merged, and we will have extra information if the failure happens again.

@guillaumemichel guillaumemichel merged commit eab1068 into master Feb 20, 2025
7 checks passed
@guillaumemichel guillaumemichel deleted the fix/1039 branch February 20, 2025 12:39
@BrewTestBot BrewTestBot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky TestFindProviderAsync
1 participant
@guillaumemichel