-
Notifications
You must be signed in to change notification settings - Fork 61
[JOSS Review] Paper and statement of need #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Dear @mbarzegary - we have addressed your comments, see below:
I have updated that paragraph. Essentially, most coupling tools deal with mesh interpolation and not with construction of atomic domains. I hope that this is now clearer from the description. I've also added preCICE and MpCCI as examples for generic multi-scale coupling tools in addition to the atomistic-continuum tools mentioned already in the prior iteration of the paper.
This was a good catch. We fixed this.
This is correct, they don't use the coupling. The paper were just quoted as example of discrete (atomic-scale) effects that need to be captured. We agree that this is confusing and have removed those citations. |
PS: The changes are in the still open PR #208 and not yet in the PDF on the JOSS review page. |
Dear authors,
The provided paper is comprehensive and well-written. However, these comments may help improve it:
P.S. This issue is related to openjournals/joss-reviews#5668
The text was updated successfully, but these errors were encountered: