added update functions #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hope that's alright. Couldn't decide which names would be best for the dummy functions required for ref and set-ref in the define/generic forms. Hopefully there won't be alternate versions of ref or set-ref in the future that would be more deserving of said names ;)
lexi-lambda
requested changes
Jul 10, 2019
| (define set-ref set-nth)])) | ||
| (define set-ref set-nth) | ||
| (define update-ref update-nth)] | ||
| ) |
There was a problem hiding this comment.
Please don’t put close parentheses on their own line.
|
Are sets "intended" to be indexable by natural number even though there isn't a definitive order of elements? That's what's causing the test failures |
When I realised they worked with ref and set-ref, I tested them and seemed to get consistent results regarding the ordering of the first two items. However, I don't think the test is helpful, and the results clearly aren't consistent. I'll remove the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope that's alright. Couldn't decide which names would be best for the dummy functions required for ref and set-ref in the define/generic forms. Hopefully there won't be alternate versions of ref or set-ref in the future that would be more deserving of said names ;)