NaN handling #21
Merged
NaN handling #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
leoasis
requested changes
Sep 27, 2016
| @@ -84,4 +84,15 @@ describe('immutableStateInvariantMiddleware', () => { | |||
| dispatch({type: 'SOME_ACTION', x}); | |||
| }).toNotThrow(); | |||
| }); | |||
|
|
|||
| it('works correctly with NaN', () => { | |||
There was a problem hiding this comment.
Can we move these tests into the proper file? Since this is a change made in trackForMutations.js, the place to write tests for it is /test/trackForMutations.spec.js. Also, take a look there that we have the tests cases in an object that describes them, both for mutations and for non mutations. You should add an entry to the nonMutations object here: https://github.com/matthieu-foucault/redux-immutable-state-invariant/blob/b21595635a88d3c4e8223f2bb7203c140415fb72/test/trackForMutations.spec.js#L175
leoasis
approved these changes
Oct 3, 2016
|
Great, thanks for your contribution again! Merging this |
|
Yeah!!! Thank you for this commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it's rare, you can end up with a NaN in your state if it's the output of a mathematical function.
NaN is tricky:
NaN === NaN; // falseNumber.NaN === NaN; // falseNumber.isNaN(NaN); // trueThis PR prevents the middleware from throwing if there is a NaN in the state