Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to detect reference updates (equal, but not identical) #5

Closed
nevir opened this issue Oct 26, 2015 · 3 comments
Closed

Comments

@nevir
Copy link

nevir commented Oct 26, 2015

reducer(state = {}, action) {
  // I would expect this to trigger an error, but it doesn't
  state.foo = {};
  return state;
}

One I give it differing values, it does:

let count = 0;
reducer(state = {}, action) {
  // boom
  state.foo = {count: count++};
  return state;
}
@leoasis
Copy link
Owner

leoasis commented Oct 26, 2015

Nice catch, will try to fix it soon

@nevir
Copy link
Author

nevir commented Oct 27, 2015

Awesome :)

@leoasis
Copy link
Owner

leoasis commented Nov 12, 2015

@nevir I've pushed some changes to the logic to detect mutations, and this should be fixed. I'll release a new version soon but if you want/need this now you can test with current master. Feel free to reopen if this is still not working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants