Skip to content

Start doing Architectural Decision Records (ADRs) #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

Iku-turso
Copy link
Contributor

As reference for Architecture Decision Records, there's this article.

This PR also introduces related CLI-tool to maintain the ADRs, adr-tools.

@Iku-turso Iku-turso added this to the 5.6.0 milestone Jun 23, 2022
@Iku-turso Iku-turso requested a review from a team as a code owner June 23, 2022 08:01
@Iku-turso Iku-turso requested review from lounjukk and DmitriyNoa and removed request for a team June 23, 2022 08:01
@jansav jansav requested review from jansav and jakolehm and removed request for lounjukk and DmitriyNoa June 23, 2022 08:11
@jansav jansav assigned Iku-turso and unassigned jakolehm and jansav Jun 23, 2022
@Nokel81
Copy link
Collaborator

Nokel81 commented Jun 23, 2022

How does this introduce adr-tools?

@jansav
Copy link
Contributor

jansav commented Jun 28, 2022

How does this introduce adr-tools?

Hm. It doesn't. I'll update the PR to contain them in near future since this is not that important yet.

@jansav jansav force-pushed the start-doing-architectural-decision-records branch from a2f1e03 to 5403997 Compare July 8, 2022 09:55
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81 Nokel81 modified the milestones: 6.0.0, 6.1.0 Jul 21, 2022
…create initial ADR

Co-authored-by: Janne Savolainen <[email protected]>

Signed-off-by: Iku-turso <[email protected]>
Signed-off-by: Janne Savolainen <[email protected]>
@jansav jansav force-pushed the start-doing-architectural-decision-records branch from 5403997 to c0ecc87 Compare August 10, 2022 11:19
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jansav jansav merged commit 730db20 into master Aug 10, 2022
@jansav jansav deleted the start-doing-architectural-decision-records branch August 10, 2022 11:36
@Nokel81 Nokel81 mentioned this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants