Skip to content

Installing extensions UI improvements #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Conversation

ixrock
Copy link
Contributor

@ixrock ixrock commented Nov 25, 2020

Features

  • redesigned & simplified UI/UX
  • allow to install extension from system path besides URL

Bugfixes

  • InputValudators.isUrl and InputValudators.isPath should not be valid for empty string
  • <SearchInput> clear-text-icon was broken without actually required onClear prop
  • <DropFileInput> was skipping className from modifying target element

close #1513

Screenshots

Screenshot 2020-11-25 at 15 25 31

Screenshot 2020-11-25 at 15 25 47

Signed-off-by: Roman [email protected]

@ixrock ixrock added bug Something isn't working enhancement New feature or request area/extension Something to related to the extension api labels Nov 25, 2020
@ixrock ixrock requested review from jakolehm and a team November 25, 2020 13:39
@jakolehm jakolehm added this to the 4.0.0 milestone Nov 25, 2020
@@ -225,7 +225,6 @@
"electron-devtools-installer": "^3.1.1",
"electron-updater": "^4.3.1",
"electron-window-state": "^5.0.3",
"file-type": "^14.7.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused package. Tried to validate for mime-type, but seems doesn't work for .tgz

Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Big improvement 👍

@jakolehm jakolehm merged commit 7243dfd into master Nov 25, 2020
@jakolehm jakolehm deleted the extensions_install_reworks branch November 25, 2020 14:42
@jakolehm jakolehm mentioned this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension Something to related to the extension api bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension UI improvements
2 participants