Resolve extension enabled status when loading it #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauri Nevala <[email protected]>
nevalla
added
bug
nevalla
commented
Nov 23, 2020
| @@ -34,11 +34,6 @@ export class ExtensionsStore extends BaseStore<LensExtensionsStoreModel> { | |||
| await extensionLoader.whenLoaded; | |||
| await this.whenLoaded; | |||
|
|
|||
| // activate user-extensions when state is ready | |||
There was a problem hiding this comment.
extensionManager has not loaded extensions at this point so we cannot determine the status here.
There was a problem hiding this comment.
Should we add above something like await extensionManager.whenReady?
Nokel81
approved these changes
Nov 23, 2020
|
This is conflicted with #1482, so let's re-implement this after it is merged. |
| this.packagesJson.dependencies[manifestJson.name] = path.dirname(manifestPath); | ||
|
|
||
| if (!isBundled) { |
There was a problem hiding this comment.
[nit] mutation could be avoided: const isEnabled = isBundled || extensionsStore.isEnabled(installedManifestPath);
panuhorsmalahti
approved these changes
Nov 24, 2020
Signed-off-by: Lauri Nevala <[email protected]>
Signed-off-by: Lauri Nevala <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1471
Signed-off-by: Lauri Nevala [email protected]