Set scrollbar colors as global styles #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <[email protected]>
Signed-off-by: Alex Andreev <[email protected]>
Signed-off-by: Alex Andreev <[email protected]>
Signed-off-by: Alex Andreev <[email protected]>
Nokel81
reviewed
Nov 23, 2020
Signed-off-by: Alex Andreev <[email protected]>
ixrock
approved these changes
Nov 25, 2020
| } | ||
|
|
||
| overflow-y: overlay !important; | ||
| overflow-y: overlay!important; |
There was a problem hiding this comment.
It overrides overflow: auto inline styles defined by VirtualList component.
There was a problem hiding this comment.
Or by react-window internals did you mean?
Merged
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies using themable scrollbar colors and eliminates of using sass
custom-scrollbarmixin.From now extensions will also use custom scrollbars defined in global styles for sake of consisten view across all Lens components.
Fixes #1337
Fixes #1483
Part of #1298